Make better efforts to present users with homepages for mods aka "give homes to the homeless" #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| // If we have homepage provided use that, otherwise use the kerbalstuff page or the github repo so that users have somewhere to get more info than just the abstract. | ||
| if (mod.resources != null && mod.resources.homepage != null) |
There was a problem hiding this comment.
Maybe only do the "mod.resources != null" check once?
|
For testing: |
Postremus
added a commit
that referenced
this pull request
Jul 7, 2015
Make better efforts to present users with homepages for mods aka "give homes to the homeless"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pet peeve of mine is seeing "N/A" in CKAN and not being able to get more information about a given mod.
This will have the GUI present the KerbalStuff or GitHub page (with the former superceding the latter) when
homepageisn't provided in the metadata.I suck at coding, if this can be done more efficiently please let me know.