Catch WebException when downloading metadata #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also continue with downloading metadata from other repositories fixes part of #1238
|
On Linux/mono 3.2.8 and no internet connectivity hitting "refresh metadata" results in all metadata being lost with this change (no message or anything). Having said that, we might have the same problem without this change, I haven't tested. :) |
|
Yup, same thing happens without this change. Also when one repo failed to update, all would fail before. |
| @@ -131,7 +131,16 @@ internal static void UpdateRegistry(Uri repo, Registry registry, KSP ksp, IUser | |||
| { | |||
| log.InfoFormat("Downloading {0}", repo); | |||
|
|
|||
| string repo_file = Net.Download(repo); | |||
| string repo_file = String.Empty; | |||
There was a problem hiding this comment.
Why initialise it to a value?
There was a problem hiding this comment.
You are right, this isn't needed in csharp. That initialization should be removed.
RichardLake
added a commit
that referenced
this pull request
Jul 17, 2015
Catch WebException when downloading metadata
HebaruSan
added
Core (ckan.dll)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also continue with downloading metadata from other repositories
fixes part of #1238