Fixed checkbox not toggling when chossing a providing mod

[Postremus]

fixes TMP on installation of any mod which relies on TMP
for example RSS and Planetshine
fixes #1298

[mheguy]

Restores the expected functionality of having a checkbox be checked when choosing a provide. Also eliminates the TMP kraken on install.

[pjf]

Woah! Was this a regression (ie: this functionality worked, and then stopped in a recent release), or have we always had this bug floating around?

[Postremus]

That bug first happened in 1.10.1, by that change: e2083ae#diff-122054cddfbbac8aa1eb19dd913efb89R173

[pjf]

@Postremus : You rock so hard, thank you.

[Postremus]

I guess "Dwarfiest Planet" will be a thing. :)

[pjf]

I'm having trouble reproducing this on mono 3.2.8 w/CKAN v1.10.2. I'm selecting RSS, it asks me which texture pack I want, I select a texture pack, and everything works fine.

Am I doing the reproduction steps wrong, or is this a runtime-dependent bug?

[Postremus]

The TMP is thrown at the user when you install the mods.

[pjf]

Woah, 3.2.8 gives me an endless exception backtrace. I'm not even sure where this starts...

  at CKAN.Main/<ModList_CellValueChanged>c__async0.MoveNext () <0x00503>
  at System.Runtime.CompilerServices.AsyncVoidMethodBuilder.Start<CKAN.Main/<ModList_CellValueChanged>c__async0> (CKAN.Main/<ModList_CellValueChanged>c__async0&) <0x0004f>
  at CKAN.Main.ModList_CellValueChanged (object,System.Windows.Forms.DataGridViewCellEventArgs) <0x0017f>
  at System.Windows.Forms.DataGridView.OnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x00069>
  at System.Windows.Forms.DataGridView.InternalOnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x00020>
  at (wrapper remoting-invoke-with-check) System.Windows.Forms.DataGridView.InternalOnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0xffffffff>
  at System.Windows.Forms.DataGridViewElement.RaiseCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x0002f>
  at System.Windows.Forms.DataGridViewCell.SetValue (int,object) <0x0021b>
  at System.Windows.Forms.DataGridViewCell.set_Value (object) <0x0002b>
  at CKAN.GUIMod.SetInstallChecked (System.Windows.Forms.DataGridViewRow,System.Nullable`1<bool>) <0x000ef>
  at CKAN.Main/<ModList_CellValueChanged>c__async0.MoveNext () <0x00503>
  at System.Runtime.CompilerServices.AsyncVoidMethodBuilder.Start<CKAN.Main/<ModList_CellValueChanged>c__async0> (CKAN.Main/<ModList_CellValueChanged>c__async0&) <0x0004f>
  at CKAN.Main.ModList_CellValueChanged (object,System.Windows.Forms.DataGridViewCellEventArgs) <0x0017f>
  at System.Windows.Forms.DataGridView.OnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x00069>
  at System.Windows.Forms.DataGridView.InternalOnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x00020>
  at (wrapper remoting-invoke-with-check) System.Windows.Forms.DataGridView.InternalOnCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0xffffffff>
  at System.Windows.Forms.DataGridViewElement.RaiseCellValueChanged (System.Windows.Forms.DataGridViewCellEventArgs) <0x0002f>
  at System.Windows.Forms.DataGridViewCell.SetValue (int,object) <0x0021b>
  at System.Windows.Forms.DataGridViewCell.set_Value (object) <0x0002b>

(edit: exception occurs when this PR has been applied.)

[pjf]

4fa7ffc brings joy to my system (Linux/mono 3.2.8)

I'm happy to merge this if anyone can confirm it works under Windows and fixes the TMP. (Although I'm still staring at the code trying to figure out how it fixes the TMP...)

[pjf]

Confirmation of Windows joy on IRC.

Merging with thanks!