Fix JObject SafeAdd to make sure underlying value is not null #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbent
changed the title
|
@dbent a fix and a test. Awesome, love your work. LGTM |
techman83
added a commit
that referenced
this pull request
Jul 19, 2015
Fix JObject SafeAdd to make sure underlying value is not null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@techman83 Fix for KSP-CKAN/NetKAN-bot#27
Problem was that converting a
nullto aJTokenstill produces aJTokenobject, but one that represents anullvalue. This makes sure that if theJTokenis notnull, that its underlying object is also notnull.Adds a regression test that fails prior to the change and passes after the change.