GUI: Numerical columns can be sorted numerically #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the creation of the 3 different sorter kinds into different methods for: string based, integer based and checkbox based fixes #1419
|
Thank you for doing this. Will be very helpful when uninstalling and installing mods. |
pjf
changed the title
| return Sort(rows, CreateDefaultSorter()); | ||
| } | ||
|
|
||
| private IEnumerable<DataGridViewRow> Sort<T>(IEnumerable<DataGridViewRow> rows, Func<DataGridViewRow, T> sortFunction) |
There was a problem hiding this comment.
Sweet! Today I learnt the Func<> keyword in C#. :)
There was a problem hiding this comment.
There was a problem hiding this comment.
@plague006 : I have no idea what I just watched, but it was amazing.
There was a problem hiding this comment.
You learned about the func. 😄
pjf
added a commit
that referenced
this pull request
Sep 10, 2015
pjf
added a commit
that referenced
this pull request
Sep 10, 2015
* 1420_adjust: Simply colum sorting to use methods rather than closures Implemented a int sorter Moved the creation of the 3 different sorter kinds into different methods for: string based, integer based and checkbox based fixes #1419
|
Merged with thanks, and a small adjustment to use methods rather than closures (cd47a9b) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the creation of the 3 different sorter kinds into different methods for:
string based, integer based and checkbox based
fixes #1419