Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed protocol handler registration on linux (at least ubuntu) #1434

Merged
merged 2 commits into from Sep 27, 2015
Merged

Fixed protocol handler registration on linux (at least ubuntu) #1434

merged 2 commits into from Sep 27, 2015

Conversation

Postremus
Copy link
Contributor

Tested on Ubuntu 14.04
-If we have no existing mimeapps.list, create it
-start ckan with mono
-make the .desktop file executable
-correctly resolve the home Directory
-focus the mod we got in the modlist
related to #1433

@ddevault
Copy link

Does not work for me here on Arch Linux. I don't get a desktop file and it's not added to mimeapps.list. How do I enable logging?

@Postremus
Copy link
Contributor Author

logging can only be activated with the Cmdline.exe, which will then start the gui:
Cmdline.exe --verbose
or
Cmdline.exe --debug

@ddevault
Copy link

3926 [1] INFO CKAN.URLHandlers (null) - Trying to register URL handler
3927 [1] INFO CKAN.URLHandlers (null) - Skipping URL handler: Parsing Error: Could not parse file ~/.local/share/applications/mimeapps.list

My mimeapps.list: https://sr.ht/Xz8G.txt

@ddevault
Copy link

👍 works for me, I just made a mistake when testing it.

@pjf
Copy link
Member

pjf commented Sep 27, 2015

Just checking if f81069e is intentionally or accidentally on this branch. :)

@Postremus
Copy link
Contributor Author

intentionally, because it also replaces some part of the url handler code.

-If we have no existing mimeapps.list, create it
-start ckan with mono
-make the .desktop file executable
-correctly resolve the home directory
related to #1433
@pjf
Copy link
Member

pjf commented Sep 27, 2015

@Postremus : Oh! That makes sense to me now. :) In the process of testing. :)

@pjf
Copy link
Member

pjf commented Sep 27, 2015

This works for me as well! Although if I've already got the CKAN open, then clicking on a ckan:// link means I then have two (as opposed to the original being signalled somehow to change its focus).

Still, that's way better than what we had before, so I'm giving the code another glance over and then merging. Thank you very much! :)

@pjf pjf merged commit 3ecfdf3 into KSP-CKAN:master Sep 27, 2015
@pjf pjf removed the Pull request label Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants