Fixups for PR #125 #146
Merged
Fixups for PR #125 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular we have a kraken when something doesn't appear to be a KSP directory, and the cmdline client tests for it in particular.
Fix verson detection and validation of KSP gamedir
- CKANTests and NetKAN are root notes. - Test classes are named after the code they exercise. - Directory structure changed to reflect this. - Test data now in `TestData.cs` for ease of re-use. For KSP-CKAN#90
Flipped IsKspDir() to internal so we can test it. Three new data directories: - `KSP/KSP-0.25` - A "good" install of KSP 0.25 - `KSP/bad-ksp` - A directory with no version info - `KSP/missing-gamedata` - A 0.25 install with no GameData dir. For KSP-CKAN#90
Git doesn't really grok empty directories. For KSP-CKAN#90.
NB: KSP.DetectVersion changed to *static*, as it uses no object data, and this is how it's used in master. * 90_test_ksp: Populated GameData in test dir to make git happy. Added tests for IsKspDir() and test data. Test framework organisation overhaul. Fix verson detection and validation of KSP gamedir Conflicts: CKAN/CKAN/KSP.cs CKAN/Tests/Test.cs
With tests! <3
- Split management of multiple instances into KSPManager - No need to manually save or load from registry. - Added GetPreferredInstance() as the best way to find the user's preferred instance, if a single preferred instance exists. - Added PortableDir() to install portable installs. - Decoupled transactional file transactions from KSP class. - KSPPathConstants in their own file - KSPPathUtils in its own file. - Some tests, but not enough, darn it! For KSP-CKAN#125
I'm really not so sure about this change. It means we no longer have problems where we try to access the registry before we have a current install, but it is a monumental pain in the ass. Luckily, this commit should also be easily reversable.
Holy smokes this works again. I have dreamed of this moment.
- `FromJson()` - `ToJson()` - `FromFile()` - `ToFile()`
|
Assigning to @AlexanderDzhoganov , as this is a PR against his work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging these, we can merge
old_125_branchinto master. :)See #125 for references. :)