Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metapackage schema #1662

Merged
merged 3 commits into from Apr 15, 2016
Merged

Metapackage schema #1662

merged 3 commits into from Apr 15, 2016

Conversation

techman83
Copy link
Member

Tested @Zane6888's correction in #1597 and it works for "download": "url" and "kind": "metapackage".

@techman83
Copy link
Member Author

Also minor correction in the Spec.md, I presume that's what you meant @plague006?

@plague006
Copy link
Contributor

Nope, kind was introduced in v1.6 via 85c7f9a

@techman83
Copy link
Member Author

Oh gosh! Not only you're right, a link to the commit and everything! Thanks @plague006 I'll amend my commit 👍

@techman83
Copy link
Member Author

And fixed.

@Dazpoet Dazpoet merged commit d15bda5 into KSP-CKAN:master Apr 15, 2016
@Dazpoet
Copy link
Member

Dazpoet commented Apr 15, 2016

And merged, hoping all goes well this time! Don't wanna be known as that-guy-who-effed-up-netkanindexing-TWICE :p

@plague006
Copy link
Contributor

You say it like it'll only be the second time you've broken everything. :D

Dazpoet added a commit that referenced this pull request Apr 15, 2016
@plague006 comment in #1662 made me remember the good ol BaconLabs.netkan incidient so I've added it to the quotes aswell as the plague006s hilarious, and accurate, comment about my ability to break things.

We totally need another guy doing more screw-ups around here T_T
@Dazpoet Dazpoet mentioned this pull request Apr 15, 2016
@techman83
Copy link
Member Author

Hahaha, you didn't wake up to your bot having munched all the metadata :P

@techman83 techman83 deleted the metapackage_schema branch April 16, 2016 06:36
ayan4m1 pushed a commit to ayan4m1/CKAN that referenced this pull request Sep 3, 2016
@plague006 comment in KSP-CKAN#1662 made me remember the good ol BaconLabs.netkan incidient so I've added it to the quotes aswell as the plague006s hilarious, and accurate, comment about my ability to break things.

We totally need another guy doing more screw-ups around here T_T
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants