Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions and error messages #2144

Merged
merged 1 commit into from Oct 16, 2017

Conversation

HebaruSan
Copy link
Member

netkan.exe's error outputs are not always as clear as they could be. In some cases important details of the error are omitted, and very rarely a sentence is simply unclear.

This code change updates the following error strings to help with investigating issues.

Error Change
JSON deserialization error Add the Exception.Message property produced by PopulateObject
Install stanzas must have a file an install_to Remove "a file" since it looks non-grammatical
Could not get the mod from SD, reason: {upstream error}. Change SD to SpaceDock, remove trailing period
Expanding {url} to full SD URL Change SD to SpaceDock
Could not normalize URL: {non URL} Add mod identifier
Could not match version with find pattern Add the version and the find pattern
Module contains no files to install. Explain the install stanzas that did not match rather than suggesting the download is empty

@Olympic1 Olympic1 merged commit e8cf13b into KSP-CKAN:master Oct 16, 2017
Olympic1 added a commit that referenced this pull request Oct 16, 2017
@HebaruSan HebaruSan deleted the fix/error-readability branch October 16, 2017 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants