Detect Breaking Ground DLC

[dbent]

(Probably) Fixes #2765

Refactors the common logic of MakingHistoryDlcDetector into a StandardDlcDetectorBase and creates a new BreakingGroundDlcDetector.

Quoting from the documentation comment:

Base class for DLC Detectors that follow standard conventions.

"Standard conventions" is defined as detecting installation by the presence of directory with the name IdentifierBaseName in the [GameData]/SquadExpansion directory, detecting version by parsing a version line in a readme.txt file in the same directory, and having an identifier of IdentifierBaseName-DLC.

Assuming Breaking Ground in fact does follow these conventions then this should be all that's required to support it. This can probably be merged after Breaking Ground is released and we confirm that it does follow the conventions.

[Olympic1]

FakeInstance should be reworked for the new DLC so it could create a fake install with both of them installed.

CKAN/Core/KSPManager.cs

Line 207 in b996c59

public void FakeInstance(string new_name, string new_path, KspVersion version, string dlcVersion = null)

The tests in CKAN/Tests/Core/Registry/Registry.cs shouldn't need an update if the naming convention stays the same.

[HebaruSan]

Looks solid, will take it for a test drive once the DLC is released. 👍

[dbent]

@Olympic1 I'll probably add support for that this weekend.

[dbent]

@HebaruSan StandardDlcDetectorBase now has an overloaded constructor which allows you to pass in a directoryBaseName. If the other ctor is used, directoryBaseName defaults to the same as identifierBaseName.

I've also removed the canonical version dictionary for... Serenity, as the first release is in fact 1.0.0 and not 1.0.

[HebaruSan]

Confirmed that it detects the DLC correctly with the latest changes. 👍

@dbent, you mentioned updating the fake instance stuff. Are you planning to add that to this PR? If so, I can wait for further review, but otherwise I think this is ready to merge.

[dbent]

I'll do that in a separate PR.

[DasSkelett]

@dbent, are you already working on the instance faking update? Else I could look into it tomorrow, if you'd prefer that.

[dbent]

@DasSkelett I have not, have at it.