Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently some modules are failing with this error:
Cause
Looking for commonalities among HyperEdit, Graphotron, and Kethane, they are 3 of the 5
$kref
s using#/ckan/http/
(SurveyTransponder and TalisarParts being the others, each last checked by the bot 21 hours ago).HttpTransformer
is assigning aUri
object into theJToken
structure:CKAN/Netkan/Transformers/HttpTransformer.cs
Lines 28 to 34 in 1ac6261
CKAN/Core/Net/Net.cs
Line 263 in 1ac6261
When NJsonSchema and Newtonsoft try to validate that
Uri
object where they are expecting a string, they fail.Changes
Now we convert the
Uri
to a string before storing it in theJToken
structure, which allows it to validate.