Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force redraw of recommendation listview headers on Mono #2920

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

HebaruSan
Copy link
Member

Problem

Sometimes (inconsistently) on Mono, the headers of the recommendations list view do not appear. This prevents the user from resizing the columns to read longer cells.

Installing SmartTank:

image

Cause

Same as #2684. Mono seems to have a bug with these headers, but I hadn't noticed it with this listview up till now.

Changes

Now the headers are always shown using the EndUpdate workaround from #2685.

@HebaruSan HebaruSan added Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request Mono Issues specific for Mono labels Nov 12, 2019
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why I never noticed it either, but indeed I can confirm now that the issue existed and is solved by this PR 👍

@HebaruSan HebaruSan merged commit ebcc5e2 into KSP-CKAN:master Nov 13, 2019
@HebaruSan HebaruSan deleted the fix/missing-rec-headers branch November 13, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Mono Issues specific for Mono Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants