Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build from scratch on Windows 7 #3122

Merged
merged 2 commits into from Jul 19, 2020
Merged

Fix build from scratch on Windows 7 #3122

merged 2 commits into from Jul 19, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jul 19, 2020 •
edited

Problem

On Windows 7, delete the _build folder and try to build:

image

Cause

Same as #2293, the script uses WebClient to download an HTTPS URL, but it doesn't support TLS1.2 by default, and nuget.org requires TLS1.2 as of April.

Changes

Now we perform the PowerShell equivalent of #2297's change in the build script. This allows WebClient to download a modern HTTPS URL.

@HebaruSan HebaruSan added Pull request Build Issues affecting the build system Windows Issues specific for Windows Network Issues affecting internet connections of CKAN labels Jul 19, 2020
DasSkelett
DasSkelett approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in Discord, can't reproduce the error on my system, but I can confirm that this change doesn't break anything for me ^^

@HebaruSan HebaruSan changed the title Fix build from scratch on Windows Fix build from scratch on Windows 7 Jul 19, 2020
@HebaruSan HebaruSan merged commit 5725d1b into KSP-CKAN:master Jul 19, 2020
@HebaruSan HebaruSan deleted the fix/win-build branch July 19, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Build Issues affecting the build system Network Issues affecting internet connections of CKAN Pull request Windows Issues specific for Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HebaruSan @DasSkelett