Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ru-RU translation #3383

Merged
merged 4 commits into from Jun 10, 2021
Merged

ru-RU translation #3383

merged 4 commits into from Jun 10, 2021

Conversation

nt0g
Copy link
Contributor

@nt0g nt0g commented May 25, 2021

Russian (ru-RU) translation.

I'd like this to be reviewed since there may be string length related problems. Some of the strings can be shortened, if needed.

initial commit
@HebaruSan HebaruSan added Enhancement GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Pull request labels May 26, 2021
@HebaruSan
Copy link
Member

HebaruSan commented May 26, 2021

Hi @nt0g, thanks for the contribution!

I'd like this to be reviewed since there may be string length related problems. Some of the strings can be shortened, if needed.

Your changes have been built into this test compile, so you can download it and try it out:

Just open the settings and select ru-RU in the language dropdown near the bottom, then close CKAN and start it again.

@nt0g
Copy link
Contributor Author

nt0g commented May 26, 2021

Some layout errors persist and can't be fixed by changing the strings.

Capture d’écran 2021-05-26 141454

Capture d’écran 2021-05-26 141543

@HebaruSan
Copy link
Member

Thanks @nt0g, I took a look and made those buttons wider, plus some other usability tweaks while we're moving things in the UI. Newest build is here:

https://github.com/KSP-CKAN/CKAN/suites/2837535996/artifacts/63283466

Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the new translation, @nt0g!
If there are any issuses with it, they'll be easy enough to fix. Merging.

@HebaruSan HebaruSan merged commit ef87c30 into KSP-CKAN:master Jun 10, 2021
@nt0g nt0g deleted the i18n_ru-RU branch June 10, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants