Set bugtracker resource for SpaceDock mods with GitHub repos #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
Easy
DasSkelett
approved these changes
May 27, 2021
I think the final count is somewhere around 350, plus or minus a few due to some GitHub rate limiting shenanigans. The next webhooks-only pass should be smaller but still quite a few, I would think. |
This was referenced May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
resources.bugtrackerproperty links to a place where users can report problems with a mod. It is available in the GUI and the status page. It can be set manually in a netkan or automatically for mods hosted on GitHub (see #3061).It would be nice to set this for mods on SpaceDock as well so we can jump to issues lists conveniently for more mods.
Changes
Now if a mod on SpaceDock has a source code link of the form
https://github.com/owner/repo/whatever, we will call out to the GitHub API to check whether that repo has issues enabled. If so, thenresources.bugtrackerwill be set to the repo's issues link.