Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prompt to overwrite dirs #3464

Merged
merged 1 commit into from Oct 17, 2021
Merged

Don't prompt to overwrite dirs #3464

merged 1 commit into from Oct 17, 2021

Conversation

HebaruSan
Copy link
Member

Problem

image

Cause

If a ZIP includes a directory that already exists and isn't registered to an installed module, ModuleInstaller.FindConflictingFiles can return it.

Changes

Now ModuleInstaller.FindConflictingFiles ignores directories.

@HebaruSan HebaruSan added Bug Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Pull request labels Oct 17, 2021
DasSkelett
DasSkelett approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce it myself yet, neither with an empty VAB folder nor with one that already contains files (or even manually installed parts of the mod), but it makes sense code-wise

@HebaruSan HebaruSan merged commit efc0a85 into KSP-CKAN:master Oct 17, 2021
@HebaruSan HebaruSan deleted the fix/overwrite-prompt-dirs branch October 17, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DasSkelett DasSkelett DasSkelett approved these changes

Assignees
No one assigned
Labels
Bug Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HebaruSan @DasSkelett