Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a few more spec version requirements #3505

Merged

Conversation

HebaruSan
Copy link
Member

#3494 and KSP-CKAN/NetKAN#8943 were fun, so I double checked the spec and found a few more requirements we aren't checking yet:

  • Installing to Scenarios requires spec version v1.14
  • Installing to Missions requires spec version v1.25
  • licenses as an array requires spec version v1.8
  • supports requires spec version v1.2

@HebaruSan HebaruSan added Enhancement Pull request Spec Issues affecting the spec Netkan Issues affecting the netkan data Relationships Issues affecting depends, recommends, etc. labels Jan 4, 2022
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DasSkelett DasSkelett merged commit aea9480 into KSP-CKAN:master Jan 19, 2022
@HebaruSan HebaruSan deleted the feature/netkan-val-spec-versions branch January 19, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Netkan Issues affecting the netkan data Pull request Relationships Issues affecting depends, recommends, etc. Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants