Only delete diversely capitalized directories once on Windows #3528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LTechContinued 1:0.5.2.2
or earlierCause
Up until its latest release (see linuxgurugamer/L-Tech#2), this mod had a
Skylab
folder and aSkyLab
folder right next to each other:On Windows, these install into a single
SkyLab
folder, but theRegistry
remembers the different names.At uninstall, CKAN tries to remove both directory names. The first succeeds, and the second throws an error because it's already gone.
Changes
Now the
HashSet<string>
that we use to track folders to delete is case insensitive on Windows, similar to what we did in #3479. This will make sure that we only delete such folders one time.Fixes #3527.