Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only delete diversely capitalized directories once on Windows #3528

Merged
merged 1 commit into from Jan 31, 2022

Conversation

HebaruSan
Copy link
Member

Problem

  1. Reboot into Windows
  2. Install LTechContinued 1:0.5.2.2 or earlier
  3. Try to uninstall it
Kan een gedeelte van het pad C:\Games\Kerbal Space Program\GameData\LTech\Parts\Science\SkyLab niet vinden.
Error during installation!
If the above message indicates a download error, please try again. Otherwise, please open an issue for us to investigate.
If you suspect a metadata problem: https://github.com/KSP-CKAN/NetKAN/issues/new/choose
If you suspect a bug in the client: https://github.com/KSP-CKAN/CKAN/issues/new/choose

Cause

Up until its latest release (see linuxgurugamer/L-Tech#2), this mod had a Skylab folder and a SkyLab folder right next to each other:

ZIP
contents

On Windows, these install into a single SkyLab folder, but the Registry remembers the different names.

At uninstall, CKAN tries to remove both directory names. The first succeeds, and the second throws an error because it's already gone.

Changes

Now the HashSet<string> that we use to track folders to delete is case insensitive on Windows, similar to what we did in #3479. This will make sure that we only delete such folders one time.

Fixes #3527.

@HebaruSan HebaruSan added Bug Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Pull request Windows Issues specific for Windows labels Jan 31, 2022
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(╯°□°)╯︵ ┻━┻

@HebaruSan HebaruSan merged commit 755c690 into KSP-CKAN:master Jan 31, 2022
@HebaruSan HebaruSan deleted the fix/win-uninst-err branch January 31, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Pull request Windows Issues specific for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find part of the path error at uninstall on Windows
2 participants