Make Netkan nested GameData check case insensitive #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
KSP-CKAN/NetKAN#9396 initially had an auto-generated netkan that installed to paths like
GameData/ESA_Rocket-0.1/Gamedata/Vega/AVUM.png:https://github.com/KSP-CKAN/NetKAN/actions/runs/3314556923/jobs/5473995107
No error was thrown because the ZIP contains
Gamedatainstead ofGameData, even though this is just as wrong as it would be if the author had used the standard capitalization.Changes
Now the nested GameData check is case insensitive, courtesy of
StringComparison.InvariantCultureIgnoreCase.I'll self-review this since it's simple and low risk.