Remove duplicate Install changes for upgrades

[HebaruSan]

Problem

When you upgrade a module, the GUI changeset shows two entries for the same module, an Update step and an Install step.

Cause

I think these extra changes existed along, but were hidden in GUI by CreateSortedModList until #3667 simplified the changeset UI to show what's actually being done. The !sortedChangeSet.Any(c => c.Mod.identifier == change.Mod.identifier check would have prevented an Install change in the changeset from being added to the list in the UI if an Update was already present:

CKAN/GUI/Controls/Changeset.cs

Lines 133 to 149 in 32517ba

	private void CreateSortedModList(IEnumerable<ModChange> changes, ModChange parent = null)
	{
	var notUserReq = changes
	.Where(c => !(c.Reason is SelectionReason.UserRequested))
	.Memoize();
	foreach (ModChange change in changes)
	{
	bool goDeeper = parent == null || change.Reason.Parent.identifier == parent.Mod.identifier;
	if (goDeeper)
	{
	if (!sortedChangeSet.Any(c => c.Mod.identifier == change.Mod.identifier && c.ChangeType != GUIModChangeType.Remove))
	sortedChangeSet.Add(change);
	CreateSortedModList(notUserReq, change);
	}
	}
	}

Changes

Now the resolver's Install step is only added to the changeset if there isn't already an Update step for the same mod.

[techman83]

Aha, that makes sense!