Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netkan check for Ships/Script spec_version #3713

Merged
merged 1 commit into from Nov 21, 2022

Conversation

HebaruSan
Copy link
Member

Background

kOS scripts are installed to Ships/Script. We added support for this in #3180, including a Netkan validation check that the spec_version was v1.29 or later, since earlier versions of CKAN wouldn't support it.

Problem

The check only triggers for one specific case:

install:
  - install_to: Ships/Script

There are other ways to install into that path:

install:
  - file: some/path/Script
    install_to: Ships
install:
  - find: some/path/Script
    install_to: Ships
install:
  - file / find: whatever
    install_to: Ships
    as: Script

Remembered while reviewing KSP-CKAN/NetKAN#9443, which almost slipped by with a bad spec_version because of it.

Changes

Now the Netkan validation checks for these other cases. It may still miss some things, but it's better than no check at all.

@HebaruSan HebaruSan added Bug Pull request Netkan Issues affecting the netkan data labels Nov 19, 2022
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense!

@HebaruSan HebaruSan merged commit d4055e7 into KSP-CKAN:master Nov 21, 2022
@HebaruSan HebaruSan deleted the fix/ships-script-check branch November 21, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Netkan Issues affecting the netkan data Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants