Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide fake instance creation in GUI #3839

Merged
merged 1 commit into from May 18, 2023

Conversation

HebaruSan
Copy link
Member

Problem

Users somewhat frequently ask why they get an error when they try to launch the game for a fake instance (see #2665):

Cause

These are created via the "Fake new KSP instance" option:

image

I think we added this on the general principle that features should be available in CmdLine, ConsoleUI, and GUI when possible. But creating a non-functional game folder is not something that normal users need to do, and its availability causes confusion. Some seem to assume they can make it install an arbitrary game version, without considering why the option they're clicking on says "fake".

Changes

Now instance faking is removed from GUI. The dropdown in Manage Game Instances now says "Clone instance" (translation updates attempted) and is disabled if no instance is selected in the grid:

image

Once you select an instance, it's enabled:

image

If you click it, the dialog appears, with all of the UI elements associated with "fake" removed:

image

The instance in the dropdown will match the row you selected in Manage Game Instances but can still be changed.

This should more firmly guide users towards cloning (which is useful to them) and away from faking (which is not). It also conveniently sidesteps the need to create faking functionality for KSP2 in GUI (which doesn't have KSP1's DLCs, meaning a more complex UI would be needed). The ckan instance fake command is still available for expert users and CI/CD, and has not been changed.

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix GUI Issues affecting the interactive GUI labels May 17, 2023
@HebaruSan HebaruSan requested a review from techman83 May 17, 2023 20:35
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean, this has been a common source of confusion, so I'm super glad to see it cleaned up.

@HebaruSan HebaruSan merged commit ac7bd71 into KSP-CKAN:master May 18, 2023
10 checks passed
@HebaruSan HebaruSan deleted the fix/hide-gui-fake-inst branch May 18, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants