Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify remote swinfo network errors #3843

Merged
merged 1 commit into from May 21, 2023

Conversation

HebaruSan
Copy link
Member

Background

#3817 added retrieval of remote swinfo.json files for KSP2 mods, which are very analogous to remote version files.

Problem

If the version_check property contains a URL that's a broken link, the error message isn't clear. It's just a generic 404 error that could be coming from anywhere:

image

Changes

Now that exception is caught and replaced with one indicating the context in which the error occurred:

$ netkan.exe --game KSP2 NetKAN/ManeuverNodeController.netkan
2233 [1] FATAL CKAN.NetKAN.Program (null) - Error fetching remote swinfo https://raw.githubusercontent.com/schlosrat/ManeuverNodeController/master/maneuver_node_controller/swinfo.json: The remote server returned an error: (404) Not Found.

I might self-review this since it only affects the bot and would be nice to have soon-ish.

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix Netkan Issues affecting the netkan data Network Issues affecting internet connections of CKAN labels May 20, 2023
@HebaruSan HebaruSan requested a review from techman83 May 20, 2023 21:02
@HebaruSan HebaruSan merged commit 4beea0f into KSP-CKAN:master May 21, 2023
10 checks passed
@HebaruSan HebaruSan deleted the fix/netkan-remote-swinfo-err branch May 21, 2023 21:27
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement Netkan Issues affecting the netkan data Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants