Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Linux .desktop files #3927

Merged
merged 4 commits into from Nov 12, 2023
Merged

Clean up Linux .desktop files #3927

merged 4 commits into from Nov 12, 2023

Conversation

irasponsible
Copy link
Contributor

Fixed a typo in debian/ckan-cmdprompt.desktop ('propmt' -> 'prompt'), and remove all 3 .desktop files from Utilities.
If it's to go anywhere outside of Games, it would probably be better in Database or Development, I think.

Remove from Utilities
Fix typo "propmt"; Remove from Utilities.
Remove from Utilities. Title case.
@HebaruSan
Copy link
Member

Thanks for the fixes, @irasponsible! I think Utility was added because CKAN itself isn't actually a game per se so it didn't quite feel right adding it only there. Game Utility or a Utility category within Game would have been perfect. But yeah, it probably doesn't belong alongside disk space graphers or calculators.

Fortunately while looking for an official guide on this question, I found the .desktop file specification has some official lists:

PackageManager may be more appropriate than Game, what do you think?

There's a ConsoleOnly that we could add to both of the non-GUI ones as well.

@HebaruSan HebaruSan added Bug Linux Issues specific for Linux Package: deb Issues affecting the Debian packaging Package: rpm Issues affecting RPM packaging labels Nov 12, 2023
@HebaruSan HebaruSan changed the title .deb Desktop Files Clean up Linux .desktop files Nov 12, 2023
Switch to PackageManager and ConsoleOnly categories
Copy link
Member

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I've moved it to the PackageManager category as suggested so a user finding it in "Game" doesn't feel disappointed when it isn't fun after launching it.

@HebaruSan HebaruSan merged commit f5ecaa0 into KSP-CKAN:master Nov 12, 2023
10 checks passed
@irasponsible
Copy link
Contributor Author

But yeah, it probably doesn't belong alongside disk space graphers or calculators.

I was looking at the same spec, trying to see if it defines Utilities, since that was my exact thought too.

I think having it in Game as well is a good idea - putting it in only PackageManager (at least with Cinnamon) relegates it to "other programs", hiding it from the menu. Maybe in both PackageManager and Game, or PackageManager and Network? If anyone disagrees too much, they can always edit the .desktop themselves! (like I did)

@HebaruSan
Copy link
Member

OK, added it back in fe366fe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Linux Issues specific for Linux Package: deb Issues affecting the Debian packaging Package: rpm Issues affecting RPM packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants