Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause after administrator error message #3966

Merged
merged 1 commit into from Dec 20, 2023

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Dec 19, 2023

Problem

Users attempting to run GUI as a Windows administrator have reported that the console window appears and disappears before they have a chance to see what it says (see #3956 and #3965).

Changes

  • Now we use a "Press any key to exit" prompt to keep the window visible and only close it after the user presses a key.
  • The message now describes the risks involved in more detail.

This should allow users to understand what's happening and make an informed decision.

image

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix Cmdline Issues affecting the command line labels Dec 19, 2023
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think this'll be good enough for the purpose. Thanks @HebaruSan

@HebaruSan HebaruSan merged commit 9d7a95e into KSP-CKAN:master Dec 20, 2023
8 checks passed
@HebaruSan HebaruSan deleted the feature/admin-press-any-key branch December 20, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmdline Issues affecting the command line Easy This is easy to fix Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants