Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install meta tester at system level again #3968

Merged
merged 1 commit into from Dec 20, 2023

Conversation

HebaruSan
Copy link
Member

Problem

The meta tester is broken.

image

Cause

In #3958 I added --user to the pip3 install, because I thought it would be cleaner than copying /usr/local from one image to the next. However, when it runs these images, GitHub sets $HOME to /github/home, which they map to a folder they control:

image

This takes /root/.local/lib/python3.10, which is where all our modules are installed, out of Python's module search path, which breaks everything. (It also makes for a very confusing problem because my docker run commands seemed to work fine until I spotted HOME in that long list of environment variables.)

Changes

Now we install to /usr/local again and copy it forward. Impact on image size is negligible:

REPOSITORY                         TAG       IMAGE ID       CREATED             SIZE
meta_tester_testing                latest    7e633c3513db   11 minutes ago      376MB

@HebaruSan HebaruSan added Bug Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels Dec 20, 2023
@HebaruSan HebaruSan merged commit 3e8950a into KSP-CKAN:master Dec 20, 2023
8 checks passed
@HebaruSan HebaruSan deleted the fix/meta-tester-home branch December 20, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant