Put auto-installed mods in ignored modpack group by default #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the export modpack option includes every installed module except DLC (and DarkKAN mods, but the less said of them the better).
By default, auto-installed mods are included, meaning that when you install that modpack, they won't be marked as auto-installed. We have received feedback expressing an interest in splitting these out so the auto-installed flag can be preserved.
Changes
Now auto-installed mods are put in the Ignored group by default. Users who wish to preserve the auto-installed flag can export the default modpack as-is, and the same mods will be pulled in as dependencies when the modpack is installed. Users who wish to add some of those mods to the modpack may do so by moving them to another group as usual.
I think this was something I considered doing originally, but I wasn't happy about the idea of .ckan files not accurately reflecting your entire mod list. However, since
providesmods will not be marked auto-installed by default, and because the user will still be able to choose to include auto-installed mods if they wish, I am convinced that the benefits outweight the risks.Fixes #3975.