Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass image from smoke to deploy, restore build caching #4093

Merged
merged 1 commit into from
May 21, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

Currently we build the Inflator image twice when pushing to master, once for smoke testing and again for pushing to Docker Hub. This is a small but not tiny amount of extra time and repeated work.

Another few extra seconds are spent re-downloading build dependencies that formerly were cached in the old workflows.

Changes

This should eliminate some redundant work.

@HebaruSan HebaruSan added Enhancement Build Issues affecting the build system Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Performance Something's slower than it should be labels May 21, 2024
@HebaruSan HebaruSan merged commit 703aeb6 into master May 21, 2024
6 checks passed
@HebaruSan HebaruSan deleted the refactor/docker-workflows branch May 21, 2024 04:54
@HebaruSan
Copy link
Member Author

HebaruSan commented May 21, 2024

Two learnings:

  1. It seems to still rebuild the image between load and push. I guess the export doesn't include caching.
  2. The redeploy commands need AWS_REGION rather than AWS_DEFAULT_REGION 😵‍💫
    Oops, no. We needed to tell docker run to make AWS_DEFAULT_REGION available inside the container with -e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues affecting the build system Enhancement Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Performance Something's slower than it should be
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant