-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metadata for GroundConstruction-Core package. #5282
Conversation
Added ModuleManager and AT-Utils as dependencies to ThrottleControlledAvionics metadata.
Added ModuleManager to dependencies. Filtered out unneded KSP-AVC version file.
Added author, abstract, homepage and manual. Removed Toolbar from suggestions.
I've updated this mod to KSP-1.2 and published it on SpaceDock.
They were trying to instal the same core configuration files. I've factored them out into another pseudopackage: ConfigurableContainers-Core.
It is a reference to the actual .netkan file maintained in its repository.
Real metadata is managed in my repo.
Need to run the build again: I send PR before the archive have uploaded to SpaceDock. |
I rephrase: how can I re-launch the checks if I have nothing to add in terms of commits? |
@allista Silly idea, but could you maybe add a ... "fix whitespace" commit in some file? Also, are you sure that the missing SpaceDock file was the reason for the build failure? The log says:
|
Yep, will do that. Positive. The structure of the archive was changed in that way in the last version (which has failed to upload at first yesterday). |
I see. Well, since you uploaded new commits and the checks failed anyway, it seems that you would theoretically have to create a new pull request to get green checkmarks. Does it matter though? Is there an auto-merge feature? I think a friendly human should be able to merge it anyway. |
Local build/install with netkan.exe/ckan.exe works fine.
Just in case, pinging to let you know that everything is OK and ready to be merged. |
@allista to force a rebuild, use #rebuild (and this comment may do it as well) |
@linuxgurugamer thanks for the info! |
Has this propagated to the CKAN index correctly? GroundConstruction-Core is still not showing up in my index. |
It has not. The netkan issue about this is here: |
* Added metadata for AT-Utils library. Added ModuleManager and AT-Utils as dependencies to ThrottleControlledAvionics metadata. * Added KerbalJointReinforcement to suggested packages. * Updated AT-Utils.netkan. Added ModuleManager to dependencies. Filtered out unneded KSP-AVC version file. * Updated ThrottleControlledAvionics.netkan Added author, abstract, homepage and manual. Removed Toolbar from suggestions. * Defrosted Hangar metadata. I've updated this mod to KSP-1.2 and published it on SpaceDock. * Added metadata for the new ConfigurableContainers mod. * Removed final comma from an array to comply with strict json. * Fixed the conflict between AT-Utils and ConfigurableContainers. They were trying to instal the same core configuration files. I've factored them out into another pseudopackage: ConfigurableContainers-Core. * Moved metadata to my own repositories. * Added metadata for GroundConstruction. It is a reference to the actual .netkan file maintained in its repository. * Added metadata for GroundConstruction-Core package. Real metadata is managed in my repo. * Dummy commit to re-launch automatic checks on Jenkins. Local build/install with netkan.exe/ckan.exe works fine.
No description provided.