Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata for GroundConstruction-Core package. #5282

Merged
merged 18 commits into from
Feb 24, 2017

Conversation

allista
Copy link
Contributor

@allista allista commented Feb 22, 2017

No description provided.

Added ModuleManager and AT-Utils as dependencies to
ThrottleControlledAvionics metadata.
Added ModuleManager to dependencies.
Filtered out unneded KSP-AVC version file.
Added author, abstract, homepage and manual.
Removed Toolbar from suggestions.
I've updated this mod to KSP-1.2 and published it on SpaceDock.
They were trying to instal the same core configuration files. I've factored them
out into another pseudopackage: ConfigurableContainers-Core.
It is a reference to the actual .netkan file maintained in its repository.
Real metadata is managed in my repo.
@allista
Copy link
Contributor Author

allista commented Feb 22, 2017

Need to run the build again: I send PR before the archive have uploaded to SpaceDock.

@allista
Copy link
Contributor Author

allista commented Feb 23, 2017

I rephrase: how can I re-launch the checks if I have nothing to add in terms of commits?

@fat-lobyte
Copy link
Contributor

fat-lobyte commented Feb 23, 2017

@allista Silly idea, but could you maybe add a ... "fix whitespace" commit in some file?

Also, are you sure that the missing SpaceDock file was the reason for the build failure? The log says:

6130 [1] FATAL CKAN.NetKAN.Program (null) - No files found in GameData/GroundConstruction/Parts/DIYKit to install!

@allista
Copy link
Contributor Author

allista commented Feb 23, 2017

Yep, will do that.

Positive. The structure of the archive was changed in that way in the last version (which has failed to upload at first yesterday).

@fat-lobyte
Copy link
Contributor

I see. Well, since you uploaded new commits and the checks failed anyway, it seems that you would theoretically have to create a new pull request to get green checkmarks.

Does it matter though? Is there an auto-merge feature? I think a friendly human should be able to merge it anyway.

Local build/install with netkan.exe/ckan.exe works fine.
@allista
Copy link
Contributor Author

allista commented Feb 24, 2017

Just in case, pinging to let you know that everything is OK and ready to be merged.

@linuxgurugamer
Copy link
Contributor

@allista to force a rebuild, use #rebuild (and this comment may do it as well)
i'll take a look and merge if it's good

@linuxgurugamer linuxgurugamer merged commit e957b8d into KSP-CKAN:master Feb 24, 2017
@allista
Copy link
Contributor Author

allista commented Feb 24, 2017

@linuxgurugamer thanks for the info!

@ahmedcharles
Copy link

Has this propagated to the CKAN index correctly? GroundConstruction-Core is still not showing up in my index.

@allista
Copy link
Contributor Author

allista commented Feb 27, 2017

It has not. The netkan issue about this is here:
#5289

blowfishpro pushed a commit to blowfishpro/NetKAN that referenced this pull request Apr 25, 2017
* Added metadata for AT-Utils library.

Added ModuleManager and AT-Utils as dependencies to
ThrottleControlledAvionics metadata.

* Added KerbalJointReinforcement to suggested packages.

* Updated AT-Utils.netkan.

Added ModuleManager to dependencies.
Filtered out unneded KSP-AVC version file.

* Updated ThrottleControlledAvionics.netkan

Added author, abstract, homepage and manual.
Removed Toolbar from suggestions.

* Defrosted Hangar metadata.

I've updated this mod to KSP-1.2 and published it on SpaceDock.

* Added metadata for the new ConfigurableContainers mod.

* Removed final comma from an array to comply with strict json.

* Fixed the conflict between AT-Utils and ConfigurableContainers.

They were trying to instal the same core configuration files. I've factored them
out into another pseudopackage: ConfigurableContainers-Core.

* Moved metadata to my own repositories.

* Added metadata for GroundConstruction.

It is a reference to the actual .netkan file maintained in its repository.

* Added metadata for GroundConstruction-Core package.

Real metadata is managed in my repo.

* Dummy commit to re-launch automatic checks on Jenkins.

Local build/install with netkan.exe/ckan.exe works fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants