Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpaceCore kOS Script Pack from SpaceDock #7967

Merged
merged 5 commits into from
Nov 6, 2020

Conversation

netkan-bot
Copy link
Member

@netkan-bot netkan-bot commented Jun 9, 2020

This pull request was automatically generated by SpaceDock on behalf of bodryxon, to add SpaceCore kOS Script Pack to CKAN.

Please direct questions about this pull request to bodryxon.

Mod details:
Name = SpaceCore kOS Script Pack
Author = bodryxon
Abstract = SpaceCore is a pack of scripts for kOS mod to launch and operate your rockets. It is universal and can be used for most launch vehicles and spacecraft.
License = MIT
Homepage =
Description =
This is your mod listing! You can edit it as much as you like before you make it public.

To edit this text, you can click on the "Edit this Mod" button up there.

By the way, you have a lot of flexibility here. You can embed YouTube videos or screenshots. Be creative.

You can check out the SpaceDock markdown documentation for tips.

Thanks for hosting your mod on SpaceDock!


ckan compat add 1.9

This is an automated commit on behalf of bodryxon
This is an automated commit on behalf of bodryxon
@HebaruSan
Copy link
Member

This contains several loose *.ks files in the root of the ZIP. Checking the kOS documentation, I can't tell where we're supposed to put these.

@HebaruSan
Copy link
Member

http://ksp-kos.github.io/KOS_DOC/general/volumes.html#archive

  • Files in the Archive are stored on your computer in the subdirectory: Ships/Script. You can pull them up in a text editor of your choice and edit them directly, and the KOS Mod will see those changes in its archive immediately.

http://ksp-kos.github.io/KOS_DOC/general/volumes.html#file-storage-behind-the-scenes

  • If a file is stored on the volume called “Archive” (or volume number zero to put it another way), then behind the scenes it’s really stored as an actual file, with the extension .ks, on your computer (As of right now it’s located in Ships/Script but that location is likely to change to somewhere in GameData in a future version.) Each program is a simple text file you can edit with any text editor, and your edits will be seen immediately by KOS the next time it tries running that program from the archive volume.

So the path might be Ships/Script. If that's so, then it might not be possible to install this with CKAN, as I don't think we allow creation of folders under Ships.

@HebaruSan
Copy link
Member

Confirmed, installation to Ships/Script isn't allowed:

$ ~/Downloads/KSP/CKAN/_build/netkan.exe NetKAN/SpaceCorekOSScriptPack.netkan 
2460 [1] WARN CKAN.NetKAN.Validators.VrefValidator (null) - Unknown install_to Ships/Script
2469 [1] FATAL CKAN.NetKAN.Program (null) - Unknown install_to Ships/Script

@HebaruSan
Copy link
Member

It works! 🎉
But the spec version validation didn't trigger because the install_to doesn't contain the full Ships/Script string. 😞

@HebaruSan HebaruSan merged commit 6c525df into master Nov 6, 2020
@HebaruSan HebaruSan deleted the add-SpaceCorekOSScriptPack branch November 6, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants