For #2338 - sphinx.util.compat is deprecated #2339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dunbaratu
added a commit
to Dunbaratu/KOS-1
that referenced
this pull request
Nov 29, 2018
The repository in the PR is marked as "unknown", meaning it might have been removed after the PR was made. So instead I'm implementing what was in the PR by re-typing it.
|
@Mararin - I'm closing this because I psuedo-merged it by just re-typing the change myself. I had to do this because github isn't telling me the branch the PR came from. It's showing as "unknown repository", which makes me think it may have been deleted after the PR got made. |
Dunbaratu
added
the
manual merge-ish
|
Yeah, I made some newbie mistakes on the original repository and decided it was going to be easier to just start from scratch, sorry about that. |
|
It's all good. I just wanted to make a paper trail documenting that even though this looks like it never got merged, it kinda did in a way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just removing this dependency doesn't appear to break anything (yet).