Add support for Program Modifiers #2423
Conversation
siimav
changed the title
|
Download the artifacts for this pull request: |
| { | ||
| if (ProgramHandler.Instance.IsProgramActiveOrCompleted(pm.srcProgram)) | ||
| { | ||
| pm.Apply(this); |
There was a problem hiding this comment.
What if you define two PM config with different source programs that modifies the same target program, you'd apply both and I am not sure the result would be deterministic here or be the intended effect?
There was a problem hiding this comment.
PMs get applied in the order they are configured and thus the effects should be deterministic.
There was a problem hiding this comment.
So since "modifiers" just a new value configuration, the last one configured is the only one used at the end right? or could we do partial PM configs that could be combined? (One defines nee confidence, one defines new fundingcurve)
|
Looking at the code, it might be possible to do an improvement where you could define a comma-separated list of srcProgram and have a AreActiveOrCompleted function instead. If would be considered a AND. It could enable scenarios like boosting both Early Sat programs if you have both Rocket Dev and Suborbital Research active or completed. |
Honestly that's not what I'm interested in right now. This should be tackled separately once we decide that such a feature is needed. |
siimav
force-pushed
the
PMs
branch
3 times, most recently
from
558921a
to
4700ed4
Compare
These will change the funding, duration etc values on a program if another gets accepted.
These will change the funding, duration etc values on a program if another gets accepted.