Benjee10_SharedAssets RO Configs #2966
Conversation
It's about time these got put in. Used in multiple mods and needs to be standardized as such. Covers the CBM, NDS/APAS/IDA, SSPV, and AJ10 Used in (almost) all Benjee10 Mods such as HabTech2, ACK, SOCK, MSSEV, etc
|
Everything should now be scaled to the correct size. However, the scale for these parts is being set elsewhere in the mod configs (notably in the Habtech 2 configs), which means the settings from these configs are not being applied. Configs other than this one should probably be removed since these parts live in Benjee10 shared assets |
|
This line is what overrides the rescale factor in Benjee's other mods, idk why he put two separate rescaleFactors in some of his parts but this fixes it I can verify your NDS rescale values but not your CBM values, the 1.8x values were properly sized (and additionally are properly sized for HabTech2 at that value) The outer ring diameter is 82 inches (2.083m) not 79 inches, Per This Document, 79 inches refers to the inner diameter, this 1.6737x rescale value is far too small. Should be between 1.7437x and 1.8x. depending on if you want to scale for inner diameter or outer. I chose 1.8x for consistency with HabTech parts while being within the correct size range. |
|
I used Freedom-era documents for reference, so it's possible that they were changed. The issue is not Benjee10s other mods, it is other RO configs. The rescaleFactors being set in this config are being changed by other rescale factors in other RO configs. They should be removed. |
|
The ISS CBM did grow between Freedom and the ISS so that makes sense. The only other config that is rescaling these parts is HabTech2, and those configs are currently outdated given the upcoming HT2 update. In addition there are two new CBM parts that the HT2 configs don't cover, so it is my opinion that anything concerning the CBM parts should be moved to SharedAssets. In the meantime, my suggestion is leaving this PR on hold or push it without the one CBM part until the official HT2 update is out and new HT2 configs are ready to support it. |
Original rescale value was correct (82in outer diameter, 79in inner) Soruce: https://imlive.s3.amazonaws.com/Federal%20Government/ID42272755263273611130549092035837226177/SSP41148.pdf
|
Well if the Habtech 2 configs are outdated, that's all the more reason to delete them in favor of the not-outdated configs here |
|
I have a new set of HabTech configs but I still have some B9 errors to sort out, and I might wait until the new update with the large modules comes out, I'm undecided on that. |
|
I have decided for you |
NDS Passive Part
|
One Last thing, NDS Passive Port. Good to go now. |
Used in multiple mods and needs to be standardized as such.
Covers the CBM, NDS/APAS/IDA, SSPV, and AJ10
Used in (almost) all Benjee10 Mods such as HabTech2, ACK, SOCK, MSSEV, etc