Work around over-eager adblockers hiding stuff they shouldn't hide #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the .follow-button class to .follow-mod-button (and .unfollow-button to .unfollow-mod-button to stay consistent). Several times users reported missing download or follow buttons. While I can't confirm it for the download button, I can reproduce it for the follow button thanks to a user reporting it together with the ad-blocker they are using. It seems to be the "Block Tracking through Social-Media-Symbols" option in Adblock Plus. It is based on the "Fanboy's Social Blocking List", which includes the filter ##.follow-button . Renaming the class to .follow-mod-button resolves the problem.
DasSkelett
added
Type: Improvement
Priority: Normal
Status: Ready
Area: Frontend
Xinayder
approved these changes
May 21, 2020
HebaruSan
approved these changes
May 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A forum user reported problems seeing the follow button on the mod page.
In a PM they said they are using Adblock Plus on Firefox.
Downloading the extension and activating the
Block social media icons trackingoption confirmed the problem:ABP uses a list called "Fanboy's Social Blocking List" if the
Block social media icons trackingis activated. That one includes filters that probably cause a lot of false positives, and in our case it's##.follow-buttonthat triggers.Changes
Rename the
.follow-buttonclass to.follow-mod-button(and.unfollow-buttonto.unfollow-mod-buttonto stay consistent).Local testing shows that it brings the follow button back.
VITAS mentioned there were also reports of the download button missing, but I can't reproduce that one. We'll have to wait for further reports for that.