-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate of garbage collection in KSP is highly increased #8
Comments
I noticed this in my old personal session too. Somehow, my CommNet instance running worse than stock CommNet on the same data. I plan to try to re-organise and streamline the whole network process of CNC later. This may have unacceptable implications for the CommNet-based RemoteTech 2 redevelopment if I can't maintain the performance of relatively simpler CNC. |
@marsfan Actually, I would like to know what you did during the mesurement of memgraph on the rover. Did you open up any CNC interface or move the rover around. Or was it simple do nothing for whole duration? It will help to narrow down to the problematic area of CNC. |
@KSP-TaxiService I did absolutely nothing, It just happens all the time. Some more info I remembered:
Thanks for being proactive about this. |
This issue will be left open for further optimization rounds and discussion. Do reach me if you have any further concern on the mod performance. |
The performance in the recent beta builds is far worse, if I take release 1.5.7 and just add commits Then I get decent performance and no nullrefs. Attatching in case someone finds it useful, no plans to maintain it unfortunately. Source is the same just cherry picked commits as mentioned, |
Upon installing this mod in KSP 1.4.3, the rate at which the game initiates garbage collections is highly increased, resulting in a stuttering gameplay.
Mods Installed:
Memgraph is not needed, I just used it to verify details. This glitch occurs even if memgraph is uninstalled.
Procedure:
2, Launch a save
3, Build a simple rover of any design
4, Launch onto runway.
When CNC is the only mod installed, the pause caused by garbage collection is manageable, but as the number of mods installed increased, the garbage collection happens even more frequently, and it pauses for longer. Without CNC, pauses occurred roughly every 30 seconds
![screenshot14](https://user-images.githubusercontent.com/9311953/40209537-637d2ce0-5a05-11e8-8f21-5257642c0625.png)
With just CNC, they occurred around every 12 seconds, and were slightly noticeable.
With a large number of other mods installed, the pauses were highly noticeable and occurred every 5 seconds. I do not have a screenshot of this ATM unfortunately. I understand that other mods exacerbate this issue, but removing CNC greatly decreased the rate at which this happened and for how long it paused.
Additionally, with only memgraph installed, each refresh of the graph shows a 1MB increase in current memory, while with CNC installed as well it can increase as much as 5MB each refresh. I suspect some memory leak is causing the GC to trigger more often.
The text was updated successfully, but these errors were encountered: