Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot dismiss or disable FastLoader opt-in popup on KSP < 1.12.0 #112

Closed
peterhaneve opened this issue Jan 18, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@peterhaneve
Copy link

peterhaneve commented Jan 18, 2023

Issue

On KSP versions under 1.12.0 (tested on KSP 1.11.1, Windows x64, KSP Community Fixes 1.24.0), the FastLoader patch will not be available. However, the opt-in dialog appears on every startup asking to opt-in to PNG texture caching and cannot be dismissed as both buttons cause an exception on click. Manually creating the file KSPCommunityFixes/PluginData/PNGTextureCache.cfg also does not work, as the patch only attempts to read and parse the file if KSP is 1.12 or higher.

Resolution

Only show the opt-in dialog (https://github.com/KSPModdingLibs/KSPCommunityFixes/blob/master/KSPCommunityFixes/Performance/FastLoader.cs#L132) if IsPatchEnabled is true. OnDestroy could probably also evade an unnecessary Harmony call as well with a similar condition.

@gotmachine gotmachine added the bug Something isn't working label Jan 19, 2023
@gotmachine
Copy link
Contributor

Whoops. Will push a fixed release.

gotmachine added a commit that referenced this issue Jan 19, 2023
gotmachine added a commit that referenced this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants