Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace one-element arrays with flexible-array members in drivers/net/ethernet/intel/i40e/i40e_type.h #335

Closed
GustavoARSilva opened this issue Aug 2, 2023 · 1 comment
Closed

Replace one-element arrays with flexible-array members in drivers/net/ethernet/intel/i40e/i40e_type.h #335

GustavoARSilva opened this issue Aug 2, 2023 · 1 comment
Assignees
@GustavoARSilva
Labels
[Idiom] fake flexible array [Linux] v6.6 Released in Linux kernel v6.6 [Refactor] 1-element array Conversion away from one-element array

Comments

@GustavoARSilva
Copy link
Collaborator 

diff -u -p a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
--- a/drivers/net/ethernet/intel/i40e/i40e_type.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
@@ -1456,7 +1456,7 @@ struct i40e_ddp_version {
 struct i40e_package_header {
        struct i40e_ddp_version version;
        u32 segment_count;
-       u32 segment_offset[1];
+       u32 segment_offset[];
 };

 /* Generic segment header */
@@ -1487,12 +1487,12 @@ struct i40e_profile_segment {
        struct i40e_ddp_version version;
        char name[I40E_DDP_NAME_SIZE];
        u32 device_table_count;
-       struct i40e_device_id_entry device_table[1];
+       struct i40e_device_id_entry device_table[];
 };

 struct i40e_section_table {
        u32 section_count;
-       u32 section_offset[1];
+       u32 section_offset[];
 };

 struct i40e_profile_section_header {
@@ -1524,7 +1524,7 @@ struct i40e_profile_aq_section {
        u16 flags;
        u8  param[16];
        u16 datalen;
-       u8  data[1];
+       u8 data[];
 };
@GustavoARSilva GustavoARSilva self-assigned this Aug 2, 2023
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 2, 2023
@GustavoARSilva @intel-lab-lkp
i40e: Replace one-element array with flex-array member in struct i40e…
665bbf2 
…_package_header

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.

The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 2, 2023
@GustavoARSilva @intel-lab-lkp
i40e: Replace one-element array with flex-array member in struct i40e…
aa0b8a6 
…_profile_segment

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 2, 2023
@GustavoARSilva @intel-lab-lkp
i40e: Replace one-element array with flex-array member in struct i40e…
5443bd9 
…_section_table

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 2, 2023
@GustavoARSilva @intel-lab-lkp
i40e: Replace one-element array with flex-array member in struct i40e…
c27e7aa 
…_profile_aq_section

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 11, 2023
@GustavoARSilva @anguy11
i40e: Replace one-element array with flex-array member in struct i40e…
fba99f8 
…_package_header

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.

The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 11, 2023
@GustavoARSilva @anguy11
i40e: Replace one-element array with flex-array member in struct i40e…
5d73537 
…_profile_segment

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 11, 2023
@GustavoARSilva @anguy11
i40e: Replace one-element array with flex-array member in struct i40e…
64c6f0d 
…_section_table

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Aug 11, 2023
@GustavoARSilva @anguy11
i40e: Replace one-element array with flex-array member in struct i40e…
3e9c2d5 
…_profile_aq_section

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
arinc9 pushed a commit to arinc9/linux that referenced this issue Aug 12, 2023
@GustavoARSilva @arinc9
i40e: Replace one-element array with flex-array member in struct i40e…
ece37d8 
…_package_header

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.

The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
arinc9 pushed a commit to arinc9/linux that referenced this issue Aug 12, 2023
@GustavoARSilva @arinc9
i40e: Replace one-element array with flex-array member in struct i40e…
35ce3ad 
…_profile_segment

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Tested-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
arinc9 pushed a commit to arinc9/linux that referenced this issue Aug 12, 2023
@GustavoARSilva @arinc9
i40e: Replace one-element array with flex-array member in struct i40e…
821633e 
…_section_table

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
arinc9 pushed a commit to arinc9/linux that referenced this issue Aug 12, 2023
@GustavoARSilva @arinc9
i40e: Replace one-element array with flex-array member in struct i40e…
441308a 
…_profile_aq_section

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
gestionlin pushed a commit to gestionlin/linux that referenced this issue Aug 13, 2023
@GustavoARSilva
i40e: Replace one-element array with flex-array member in struct i40e…
88f13a0 
…_package_header

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_package_header with flexible-array
member.

The `+ sizeof(u32)` adjustments ensure that there are no differences
in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
gestionlin pushed a commit to gestionlin/linux that referenced this issue Aug 13, 2023
@GustavoARSilva
i40e: Replace one-element array with flex-array member in struct i40e…
7e318ab 
…_profile_segment

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_segment with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Tested-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
gestionlin pushed a commit to gestionlin/linux that referenced this issue Aug 13, 2023
@GustavoARSilva
i40e: Replace one-element array with flex-array member in struct i40e…
04c071d 
…_section_table

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_section_table with flexible-array
member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
gestionlin pushed a commit to gestionlin/linux that referenced this issue Aug 13, 2023
@GustavoARSilva
i40e: Replace one-element array with flex-array member in struct i40e…
35fde12 
…_profile_aq_section

One-element and zero-length arrays are deprecated. So, replace
one-element array in struct i40e_profile_aq_section with
flexible-array member.

This results in no differences in binary output.

Link: KSPP#335
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
@kees kees added the [Linux] v6.6 Released in Linux kernel v6.6 label Feb 6, 2024
@kees
Copy link

kees commented Feb 6, 2024

Fixed in commit e55c50e, fbfa49f, ff1a724, and 4bb28b2.

@kees kees closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GustavoARSilva GustavoARSilva

Labels
[Idiom] fake flexible array [Linux] v6.6 Released in Linux kernel v6.6 [Refactor] 1-element array Conversion away from one-element array
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GustavoARSilva @kees