Fix cli package compatibility #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the following errors have come up when building:
$ go build
# github.com/ksubedi/gomove
./main.go:18:5: app.Author undefined (type *cli.App has no field or method Author)
./main.go:21:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:26:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:30:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
./main.go:37:13: cannot use func literal (type func(*cli.Context)) as type cli.ActionFunc in assignment
The `github.com/codegangsta/cli` package has been moved to
`github.com/urfave/cli`.
The latest major version of `github.com/urfave/cli` is now v2, which is
incompatible with the version `gomove` expects.
Add Go Modules manifest files with:
$ go mod init
to set a dependency on `github.com/urfave/cli` v1, fixing the build
errors.
Fixes KSubedi#6.
Was getting the following warnings, causing tests to fail:
$ go test ./...
# github.com/ksubedi/gomove
./ast.go:67:3: Println arg list ends with redundant newline
./ast.go:73:3: Println arg list ends with redundant newline
./native.go:112:3: Println arg list ends with redundant newline
./native.go:121:3: Println arg list ends with redundant newline
FAIL github.com/ksubedi/gomove [build failed]
FAIL
Since Go 1.10, `go test` runs `vet` checks:
golang/go#18085
Update the print calls to eliminate the `vet` warnings.
|
Merged, thanks for the contribution. |
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the following errors have come up when building:
The
github.com/codegangsta/clipackage has been moved togithub.com/urfave/cli.The latest major version of
github.com/urfave/cliis now v2, which isincompatible with the version
gomoveexpects.Add Go Modules manifest files with:
to set a dependency on
github.com/urfave/cliv1, fixing the builderrors.
Also takes care of
Printlnwarnings causinggo testto fail on Go >= 1.10.Fixes #6.