hemaia util #20
hemaia util #20
Conversation
There was a problem hiding this comment.
OK!
A few thoughts that you might want to consider.
-
Maybe call it
hemaia_util.pyso that it's not too generic hehe. Also the idea is, just in case someone calls their modulesutil.pyat least ours is a unique name. I'll leave it up to you if you want to change. -
Would you mind if I add later, a listing CI? I will also teach you how to use pre-commits for formatting. Haha let me know if you want this feature then I will try to add it.
target/rtl/Makefile
Outdated
| SNAX_CFGS += cfg/cluster_cfg/snax_KUL_cluster.hjson | ||
| SNAX_CFGS += cfg/cluster_cfg/snax_KUL_xdma_cluster.hjson | ||
|
|
||
| SNAX_CFGS = $(shell python3 $(HEMAIA_UTIL) --cfg_path $(CFG) --print_clusters) |
There was a problem hiding this comment.
Do you need to call python3? I think when you put the bash comment on top of util.py it's supposed to run by just ./util/hemaia/util.py. Can you try with the docker?
Also this assumes you use the SNAX docker yes?
It is in hemaia folder, so I think it is still fine😃😃 What is the listing CI? I don't know it. By the way, I had spent too many time on the Makefile to generate targets dynamically... I suggest we move rtl target to Python😭😭 |
|
@IveanEx I will do the CI thing in a different PR. I think this is a nice first step. I also agree. I don't like how we need to comply with The Makefile thing is only useful for C builds and so. But to generate RTL, make some filelists and all... they should not be in Makefiles. It only makes things more difficult... |
* Initial Commit * Update CI * Bug Fix
This PR introduces the hemaia/util.py. The aim of this dedicated script is to increase the level of automation during rtl generation and house the small function that retrieves information from cfg and irrelevant to rtl code.
Possible usage: