Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean #16

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Clean #16

merged 11 commits into from
Sep 27, 2023

Conversation

hsonne
Copy link
Member

@hsonne hsonne commented Jun 4, 2022

This change is Reviewable

hsonne and others added 11 commits June 5, 2022 00:21
Reindent, use helper variable "name", get rid
of helper variable "cols_with_problems"
Put the opening curly brace at the start of the
function body in its own line
and use kwb.utils::createFunctionExtdataFile()
to prevent:
❯ checking dependencies in R code ... NOTE
  Namespace in Imports field not imported from: 'plotly'
    All declared Imports should be used.
@hsonne hsonne merged commit 35ee852 into dev Sep 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants