Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/overwrite wallets #47

Merged
merged 2 commits into from
May 30, 2023
Merged

Fix/overwrite wallets #47

merged 2 commits into from
May 30, 2023

Conversation

RuslanGlaznyov
Copy link
Contributor

@RuslanGlaznyov RuslanGlaznyov commented May 20, 2023 •
edited
Loading

If two commands are entered twice, the wallet will be overwritten and replaced by a new one without any warning message.
This fix disallows the user to create a wallet with the name of the wallet that already exists.

./kysor valaccounts create \
--name 'moonbeam' \
--pool 0 \
--storage-priv "$(cat path/to/arweave.json)" \
--metrics

troykessler
troykessler approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@troykessler troykessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@troykessler troykessler merged commit 52d4f6c into main May 30, 2023
@troykessler troykessler deleted the fix/overwrite-wallets branch May 30, 2023 08:53
kchrist-rocketfueldev pushed a commit to harrytou/kyvejs that referenced this pull request Oct 17, 2023
@RuslanGlaznyov
Fix/overwrite wallets (KYVENetwork#47)
c9ade81 
* fix: added check by wallet name

* chore: lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troykessler troykessler troykessler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RuslanGlaznyov @troykessler