address issues 9 #16
Merged
address issues 9 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanusk
reviewed
Jul 22, 2019
src/lib.rs
Outdated
| @@ -360,27 +360,9 @@ pub fn pari_qf_comp_to_decimal_string(pari_qf: GEN, index: usize) -> String { | |||
| comp_str_slice.to_string() | |||
| } | |||
|
|
|||
| //TODO: use str::parse | |||
| pub fn decimal_string_to_bn(dec_string: String) -> BigInt { | |||
There was a problem hiding this comment.
Perhaps it would be simpler to replace all calls for decimal_string_to_bn with calls to str::parse. Seem redundant to have a function only executing one line
There was a problem hiding this comment.
make points.
@omershlo what do u think
There was a problem hiding this comment.
sorry, missed that.
Sounds good to me.
There was a problem hiding this comment.
sorry, missed that.
Sounds good to me.
no problem, will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.