Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address issues 9 #16

Merged
merged 3 commits into from Aug 11, 2019
Merged

address issues 9 #16

merged 3 commits into from Aug 11, 2019

Conversation

@HAOYUatHZ
Copy link
Contributor

HAOYUatHZ commented Jul 21, 2019

No description provided.

src/lib.rs Outdated
@@ -360,27 +360,9 @@ pub fn pari_qf_comp_to_decimal_string(pari_qf: GEN, index: usize) -> String {
comp_str_slice.to_string()
}

//TODO: use str::parse
pub fn decimal_string_to_bn(dec_string: String) -> BigInt {

This comment has been minimized.

Copy link
@amanusk

amanusk Jul 22, 2019

Member

Perhaps it would be simpler to replace all calls for decimal_string_to_bn with calls to str::parse. Seem redundant to have a function only executing one line

This comment has been minimized.

Copy link
@HAOYUatHZ

HAOYUatHZ Jul 23, 2019

Author Contributor

make points.
@omershlo what do u think

This comment has been minimized.

Copy link
@omershlo

omershlo Jul 29, 2019

Member

sorry, missed that.
Sounds good to me.

This comment has been minimized.

Copy link
@ChrisLinn

ChrisLinn Aug 2, 2019

sorry, missed that.
Sounds good to me.

no problem, will do.

@HAOYUatHZ

This comment has been minimized.

Copy link
Contributor Author

HAOYUatHZ commented Aug 11, 2019

done and tested using cargo test tests -- --test-threads=1

@omershlo @amanusk

@omershlo omershlo merged commit 325ae51 into KZen-networks:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.