\copyright, \textregistered, \textcircled support

[edemaine]

This seems to work at regular size and \small, but not e.g. in subscript. Suggestions welcome.

Based on discussions with @kevinbarabash in KaTeX/katex-fonts#9

[kevinbarabash]

@edemaine can you post what it looks like for \textstyle and \scriptstyle? Is it just the subscript that looks wrong, or is it also wrong in superscript?

[edemaine]

Here's the current state for http://localhost:7936/?text=%5Cbegin%7Bmatrix%7D%0A%5Ccopyright%5Csmall%5Ccopyright%5Cfootnotesize%5Ccopyright%5Ctiny%5Ccopyright%5C%5C%0A%5Ccopyright_%7B%5Ccopyright_%7B%5Ccopyright%7D%7D%0A%5Cend%7Bmatrix%7D%0A :

It looks like \llap is resetting the font to normalsize. This seems to be a bug in \llap, because LaTeX doesn't work that way. Er, it's more complicated than that... \small doesn't actually affect math font size in LaTeX, but does affect the text in \llap, while \llap does include the normal/script/scriptscriptstyle:

$$
\begin{matrix}
x\rlap{x} & \small x\rlap{x} & \footnotesize x\rlap{x} & \tiny x\rlap{x} \\
x\rlap{x} & \scriptstyle x\rlap{x} & \scriptscriptstyle x\rlap{x} \\
x\rlap{x} & _{x\rlap{x}} & _{_{x\rlap{x}}} \\
\end{matrix}
$$

Here's KaTeX's rendering: (sorry, I'm on Windows right now, so fonts aren't loading)

Incidentally, LaTeX does some weird stuff with resized copyrights. Here's the first example:

[kevinbarabash]

Not sure the best way to deal with the font size issues. Finding an appropriate glyph for the \copyright symbol might be easier in the short term. Another option might be to implement \mathchoice and then tweak the definition for each style.

[codecov]

Codecov Report

Merging #1073 into master will decrease coverage by 0.03%.
The diff coverage is 78.57%.

@@            Coverage Diff            @@
##           master   #1073      +/-   ##
=========================================
- Coverage   83.83%   83.8%   -0.04%     
=========================================
  Files          61      61              
  Lines        3971    3982      +11     
  Branches      659     662       +3     
=========================================
+ Hits         3329    3337       +8     
- Misses        543     546       +3     
  Partials       99      99

Impacted Files	Coverage Δ
src/macros.js	84.81% <100%> (+0.29%)	⬆️
src/symbols.js	100% <100%> (ø)	⬆️
src/functions/accent.js	90.16% <70%> (-4.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01f504...facd231. Read the comment docs.

[edemaine]

I revisited this, implementing an actual \textcircled command as an accent, like in LaTeX. This accent seems to behave differently from all other accents in that its width contributes to the width of the final symbol (cf. #1033), and it is never offset vertically. I'm not sure what triggers this in (La)TeX, but I'm calling this a "full" accent barring a better name. \copyright behaves very well now, as does \textregistered:

\copyright_{\copyright_{\copyright}} \small \copyright \tiny \copyright

This should be good to go, unless someone knows better terminology for this type of accent. Oh, also need to add tests.

[kevinbarabash]

LGTM. Thanks for seeing this through.

[kevinbarabash]

yay for macros

[kevinbarabash]

I wish we store more props directly on the domTree nodes we create so that we don't have all of this extra data hanging out in this file. No action required.

[kevinbarabash]

I see, this is just an alias.