Split up environments list into calls to defineEnvironment #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having one long array literal to contain the code of all environment implementations is problematic. It makes it difficult to add auxiliary functions or data close to the function inside the list where it is needed. Now the functions are no longer defined using such a literal, but instead using calls to a "defineEnvironment" function which receives all the relevant data. Since each function call is independent from the others, anything can go in between. This commit deliberately avoided reindenting existing code to match the new surroundings. That way it is easier to see where actual changes happen, even when not performing a whitespace-ignoring diff.
Since the previous commit deliberately avoided reindenting, this one here does just that: reindenting the existing code.
Closed
kevinbarabash
added a commit
that referenced
this pull request
Sep 15, 2015
Split up environments list into calls to defineEnvironment
|
Hmm... I probably should've had you squash those. I'll remember for the next one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of #262, discussed in #256.
Having one long array literal to contain the code of all environment implementations is problematic. It makes it difficult to add auxiliary functions or data close to the function inside the list where it is needed.
Now the functions are no longer defined using such a literal, but instead using calls to a
defineEnvironmentfunction which receives all the relevant data. Since each function call is independent from the others, anything can go in between.I've deliberately submitted this as two distinct commits. The first does the actual work, but avoids reindentation, while the second does the reindentation but has no other changes. Hopefully this will make reviewing easier. Of course I can squash that once you're satisfied.