-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probable bug in image retrieval code #64
Comments
@KaihuaTang I think those lines are required as in the scene graph encoding model ( From the code and the paper, what I understand is that the I can add some code to compute the |
text_graph should be implemented the same as image_gaph. I didn't differentiate them in structure except for the vocabulary. sorry that I lost this part of codes. preprocessing.py was merged from several independent jupyter notes. I think I forgot to paste some functions. |
I will try to figure out the missing part. Thanks for the help. Also thanks a lot for sharing this repository. Amazing work! |
@mods333 Have you figured out the missing part? because I'm kinda lost.. Thanks! :) |
Hi, I was trying to use the code for the image retrieval task. The code in 'dataloader.py
and 'preprocessing.py
seem to be somewhat inconsistent.In
dataloader.py
there is_generate_tensor_by_idx
that looks for'image_graph
and'text_graph
key in theimg_txt_sg
variableHowever in the preprocessing code the output dictionary created had only two keys
img
andtxt
I was wondering if there is something missing in the code or if I am doing something wrong.
The text was updated successfully, but these errors were encountered: