Skip to content
Browse files

rcu: Fix unpaired rcu_irq_enter() from locking selftests

commit ba9f207c9f82115aba4ce04b22e0081af0ae300f upstream.

HARDIRQ_ENTER() maps to irq_enter() which calls rcu_irq_enter().
But HARDIRQ_EXIT() maps to __irq_exit() which doesn't call

So for every locking selftest that simulates hardirq disabled,
we create an imbalance in the rcu extended quiescent state
internal state.

As a result, after the first missing rcu_irq_exit(), subsequent
irqs won't exit dyntick-idle mode after leaving the interrupt
handler.  This means that RCU won't see the affected CPU as being
in an extended quiescent state, resulting in long grace-period
delays (as in grace periods extending for hours).

To fix this, just use __irq_enter() to simulate the hardirq
context. This is sufficient for the locking selftests as we
don't need to exit any extended quiescent state or perform
any check that irqs normally do when they wake up from idle.

As a side effect, this patch makes it possible to restore
"rcu: Decrease memory-barrier usage based on semi-formal proof",
which eventually helped finding this bug.

Reported-and-tested-by: Yinghai Lu <>
Signed-off-by: Frederic Weisbecker <>
Cc: Paul E. McKenney <>
Cc: Ingo Molnar <>
Cc: Peter Zijlstra <>
Signed-off-by: Paul E. McKenney <>
Signed-off-by: Greg Kroah-Hartman <>
  • Loading branch information...
1 parent 776c67a commit f64e7b26127a4753fe6b6e84abacb18c008ac82c @fweisbec fweisbec committed with May 20, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/locking-selftest.c
2 lib/locking-selftest.c
@@ -144,7 +144,7 @@ static void init_shared_classes(void)
#define HARDIRQ_ENTER() \
local_irq_disable(); \
- irq_enter(); \
+ __irq_enter(); \
#define HARDIRQ_EXIT() \

0 comments on commit f64e7b2

Please sign in to comment.
Something went wrong with that request. Please try again.