Move translate chunks step to where it is needed

Kalior · Aug 31, 2018 · 5c68c08 · 5c68c08
1 parent 7827455
commit 5c68c08
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/action_recognition/classifiers/classification_visualiser.py b/action_recognition/classifiers/classification_visualiser.py
@@ -6,6 +6,7 @@
 import logging
 
 from ..analysis import ChunkVisualiser
+from ..transforms import TranslateChunks
 
 
 class ClassificationVisualiser:
@@ -43,7 +44,7 @@ def plot_confusion_matrix(self, labels, test_labels, class_names, title):
         plt.savefig(title + '.png', bbox_inches='tight')
         plt.show(block=False)
 
-    def visualise_incorrect_classifications(self, pred_labels, test_labels, chunks, frames, translated_chunks, videos):
+    def visualise_incorrect_classifications(self, pred_labels, test_labels, chunks, frames, videos):
         """Displays videos of the incorrect classifications.
 
         Can help with identifying features that can be added to the
@@ -63,6 +64,7 @@ def visualise_incorrect_classifications(self, pred_labels, test_labels, chunks,
             The paths to the corresponding videos of the chunks.
 
         """
+        translated_chunks = TranslateChunks().transform(chunks)
         visualiser = ChunkVisualiser(chunks, frames, translated_chunks)
         unique_labels = set(pred_labels)
         for pred_label in unique_labels:

diff --git a/train_classifier.py b/train_classifier.py
@@ -44,7 +44,6 @@ def main(args):
 def train_classifier(train, test, title, classifier, visualise_incorrect_classifications):
     train_chunks, _, train_labels, _ = train
     test_chunks, test_frames, test_labels, test_videos = test
-    test_translated_chunks = transforms.TranslateChunks().transform(test_chunks)
 
     logging.info("Fitting classifier.")
     classifier.fit(train_chunks, train_labels)
@@ -63,7 +62,7 @@ def train_classifier(train, test, title, classifier, visualise_incorrect_classif
 
     if visualise_incorrect_classifications:
         visualiser.visualise_incorrect_classifications(
-            pred_labels, test_labels, test_chunks, test_frames, test_translated_chunks, test_videos)
+            pred_labels, test_labels, test_chunks, test_frames, test_videos)
 
     file_name = "{}.pkl".format(title)
     logging.info("Saving model to {}.".format(file_name))