Patch newlib headers to expose lstat #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuzarDC
added
bug
|
Added patches for Newlib 2.0.0 and 3.3.0, but I haven't tested building anything yet. I'll test building the toolchain and libjimtcl with this change soon. |
|
Fixed an issue in your 4.4.0 patch, and built toolchains with the 4 Newlibs, all of which compile |
darcagn
approved these changes
Apr 29, 2024
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve KallistiOS/kos-ports#54 issue with libjimtcl and the missing lstat.
For whatever reason, I was getting warnings if I didn't add the extra newline at the end of the first patch file. It takes me quite a while to rebuild my toolchain, so I only actually tested the 4.4.0 and figured that perhaps others could test further back (@darcagn ?) The nature of the patch should mean that it'd be valid all the way back.