Add tests for underscore handling

Add tests for the convert_underscores option
to CommandManager.

Change-Id: I5f91bb539bce69936ea86f7a370df2412c3a913c
Signed-off-by: Doug Hellmann <doug.hellmann@dreamhost.com>

tests/test_commandmanager.py

@@ -93,3 +93,27 @@ def test_load_commands():
         assert iter_entry_points.called_once_with('test')
         names = [n for n, v in mgr]
         assert names == ['test']
+
+
+def test_load_commands_keep_underscores():
+    testcmd = mock.Mock()
+    testcmd.name = 'test_cmd'
+    mock_pkg_resources = mock.Mock(return_value=[testcmd])
+    with mock.patch('pkg_resources.iter_entry_points',
+                    mock_pkg_resources) as iter_entry_points:
+        mgr = CommandManager('test', convert_underscores=False)
+        assert iter_entry_points.called_once_with('test')
+        names = [n for n, v in mgr]
+        assert names == ['test_cmd']
+
+
+def test_load_commands_replace_underscores():
+    testcmd = mock.Mock()
+    testcmd.name = 'test_cmd'
+    mock_pkg_resources = mock.Mock(return_value=[testcmd])
+    with mock.patch('pkg_resources.iter_entry_points',
+                    mock_pkg_resources) as iter_entry_points:
+        mgr = CommandManager('test', convert_underscores=True)
+        assert iter_entry_points.called_once_with('test')
+        names = [n for n, v in mgr]
+        assert names == ['test cmd']