Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrePlanManager.lua #867

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

soumaxetuirk
Copy link

@soumaxetuirk soumaxetuirk commented Aug 14, 2020

crash fix while loading saved preplanning
remove overlapping "buy all assets" button.

Description

'_get_type_cost' renamed to 'get_type_cost'
'BuyAllAsset.lua' shoulde be removed as its now implemented by the game 199.6 update.

crash fix while loading saved preplanning
@PhantomGamers
Copy link

PhantomGamers commented Aug 14, 2020

Probably instead of deleting the BuyAllAsset code altogether we still should use the asset cost calculation stuff so that the functionality stays the same as before (displaying the total cost next to the button text).

Also MenuManager.show_confirm_mission_asset_buy_all = expect_yes should be added to MenuTweaks.lua to skip the dialog

@bscout9956
Copy link

L796 of MenuTweaks?

@PhantomGamers
Copy link

L796 of MenuTweaks?

doesn't matter which order but yes in that location

@s193067
Copy link

s193067 commented Aug 29, 2020

You can remove BuyAllAsset.lua and change _get_type_cost to get_type_cost in PrePlanManager.lua by yourself. Also MenuManager.show_confirm_mission_asset_buy = expect_yes is already in MenuTweaks.lua

@PhantomGamers
Copy link

You're right, it's buy_all, I miswrote that. Updated the comment.

@bscout9956
Copy link

bscout9956 commented Sep 30, 2020

This is due months, any plans to merge Kamikaze?

@ghost
Copy link

ghost commented Nov 10, 2020

I have forked this project and merged your PR to the fork. It looks like Kamikaze has dropped this project so for now, if you'd like to get this in, you can use this fork until Kamikaze gets back.

https://github.com/wolfhud/WolfHUD

@bscout9956 @TRTSC @PhantomGamers @soumaxetuirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants